Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serialize empty strings and lists to headers in restXml and restJson1 #2403

Merged
merged 2 commits into from
Sep 23, 2024
Merged

serialize empty strings and lists to headers in restXml and restJson1 #2403

merged 2 commits into from
Sep 23, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 23, 2024 •
edited
Loading

Background

  • What do these changes do?
    • changes header serialization test assertions to include empty strings and lists, but still exclude null
  • Why are they important?
    • absence and emptiness of headers differ in meaning

Testing

  • How did you test these changes?

Tested protocol-test codegen and test execution in smithy-typescript + aws-sdk-js-v3

Links

smithy-lang/smithy-typescript#1412

@kuhe kuhe requested a review from a team as a code owner September 23, 2024 17:14
@kstich kstich merged commit 480be03 into smithy-lang:main Sep 23, 2024
13 checks passed
@kuhe kuhe deleted the fix/header-serialization branch September 24, 2024 01:56
This was referenced Sep 24, 2024
Closed
Merged
@jbelkins jbelkins mentioned this pull request Sep 25, 2024
Closed
2 tasks
This was referenced Oct 3, 2024
Merged
Closed
Merged
@landonxjames landonxjames mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstich kstich kstich approved these changes

@milesziemer milesziemer Awaiting requested review from milesziemer milesziemer is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @kstich